Improve unit testing (Part 2)#3385
Draft
falbrechtskirchinger wants to merge 15 commits intonlohmann:developfrom
Draft
Improve unit testing (Part 2)#3385falbrechtskirchinger wants to merge 15 commits intonlohmann:developfrom
falbrechtskirchinger wants to merge 15 commits intonlohmann:developfrom
Conversation
1a35528 to
f4d0546
Compare
f4d0546 to
69a2784
Compare
Contributor
Author
|
Note to self: Add ABI string from #3590 to Edit: Done. |
cd146ae to
bd05c62
Compare
Owner
|
This starts to become a very large PR. Please consider breaking it into smaller pieces, such as the whole fuzzer part. |
bd05c62 to
b3a29f5
Compare
Contributor
Author
Yes. I'm just using this for CI. Locally I already have a separate branch for the fuzzing stuff. |
b3a29f5 to
3e30e1f
Compare
d927dfc to
89211f0
Compare
Add and use the following CMake function:
json_test_add_standard_keyphrases(
PHRASES <args>...
CXX_STANDARDS <args>...)
Create a mapping between C++ standard versions and key phrases.
json_test_add_test_for() will search for these key phrases and build
tests for associated C++ standard versions.
Use "logical" ordering for use with ordered_json.
Add a target to print JSON meta for all tested C++ standard versions.
8a27a68 to
dbf568a
Compare
dbf568a to
35f6a61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 2 of the unit test improvements.
The original plan of adding build information output has been scrapped after the code had ballooned into a 4000 line monstrosity.
Instead, this PR addresses some issues that were discussed (remove magic keywords from the unit tests) and adds a very minimal version of what the build information output would have provided by extending JSON meta and printing that at the start of each unit test or via the
print_metatarget.For example, most CI targets will now print the following for each enabled C++ standard:
To Do
meta()changes.