Refactor unit tests to use more convenient doctest assertion macros#3393
Merged
nlohmann merged 26 commits intonlohmann:developfrom Mar 24, 2022
kkarbowiak:develop
Merged
Refactor unit tests to use more convenient doctest assertion macros#3393nlohmann merged 26 commits intonlohmann:developfrom kkarbowiak:develop
nlohmann merged 26 commits intonlohmann:developfrom
kkarbowiak:develop
Conversation
nlohmann
requested changes
Mar 19, 2022
Owner
nlohmann
left a comment
nlohmann
left a comment
There was a problem hiding this comment.
There are still tests failing in the CI. Can you please update from the latest develop branch?
Contributor
Author
As far as I can tell, my fork is up to date with regards to the Also, it seems that the only CI builds that did not succeed are the |
Owner
|
The latest develop branch runs all CI tests. |
nlohmann
added
release item: 🔨 further change
and removed
please rebase
Owner
|
Thanks a lot! |
Contributor
Author
|
Thank you, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors unit tests to use more convenient doctest assertion macros, as discussed in issue #3365.
The bulk of the change was done automatically, using a regexp replace, with some manual adjustments.
In the process, I found several unit tests that rely on the side effects of running two assertion macros and got broken by running a single one. Those tests are left untouched, to keep them passing. I think I will try to address those is a separate PR.