Fix iterator_input_adapter consuming more than it should#3531
Closed
falbrechtskirchinger wants to merge 4 commits intonlohmann:developfrom
Closed
Fix iterator_input_adapter consuming more than it should#3531falbrechtskirchinger wants to merge 4 commits intonlohmann:developfrom
falbrechtskirchinger wants to merge 4 commits intonlohmann:developfrom
Conversation
Contributor
Author
|
I've tried to write a unit test and the "fixed" Parsing "[1][2]": |
Contributor
Author
|
I've now added the unit test which fails to trigger the alleged issue. |
4 tasks
Contributor
Author
|
I'm convinced this fixes nothing and breaks legitimate use cases. See #3442 for a lengthy discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As identified by @imwhocodes,
iterator_input_adapterconsumes an additional character from the input during parsing. This PR based on #3442 by @imwhocodes fixes this. I'm finishing his work by incorporating requested changes and fixing CI issues.At the moment, it's missing a unit test.
Replaces #3442.