Merged
Conversation
nlohmann
reviewed
Aug 1, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| server_side=True, ssl_version=ssl.PROTOCOL_TLS) | ||
| ssl_ctx = ssl.create_default_context(ssl.Purpose.CLIENT_AUTH) | ||
| ssl_ctx.load_cert_chain(cert_file, key_file) | ||
| httpd.socket = ssl_ctx.wrap_socket(httpd.socket, server_side=True) |
Check notice
Code scanning
Use of insecure SSL/TLS version
falbrechtskirchinger
force-pushed
the
misc-fixes
branch
from
95f889d to
9c9f5e8
Compare
Contributor
Author
|
Looks good to me. @nlohmann I'll leave it up to you whether you'd prefer collecting more small stuff here or if you'd want to merge it now. I've tested |
nlohmann
reviewed
Aug 2, 2022
falbrechtskirchinger
force-pushed
the
misc-fixes
branch
from
cb5842c to
7787930
Compare
gregmarr
reviewed
Aug 5, 2022
shaischaudhry
approved these changes
Aug 6, 2022
falbrechtskirchinger
force-pushed
the
misc-fixes
branch
from
7787930 to
5c8e359
Compare
Contributor
Author
|
Several items in here have made it into other PRs. I've removed them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serve_header.pyalways exiting with 0 error code.serve_header.py.I may leave this here for a while, in case I find more issues like this. Chances are, of course, I'll find another one moments after this one has been merged. :-)