Amalgamate the forward declaration header#3679
Merged
nlohmann merged 3 commits intonlohmann:developfrom Aug 7, 2022
Merged
Conversation
nlohmann
requested changes
Aug 5, 2022
Owner
nlohmann
left a comment
nlohmann
left a comment
There was a problem hiding this comment.
Please also adjust:
- .github/CONTRIBUTING.md
- .github/PULL_REQUEST_TEMPLATE.md
falbrechtskirchinger
force-pushed
the
amalgamate-fwd
branch
from
c733401 to
d091cc2
Compare
shaischaudhry
approved these changes
Aug 6, 2022
Contributor
Author
|
I've updated |
Contributor
Author
falbrechtskirchinger
left a comment
falbrechtskirchinger
left a comment
There was a problem hiding this comment.
Looks good to me.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, we need to amalgamate
json_fwd.hppto make it usable as a standalone file (again).