Add to CONTRIBUTING.md that make pretty is required for test updates.#4045
Merged
nlohmann merged 1 commit intonlohmann:developfrom Jun 8, 2023
Merged
Add to CONTRIBUTING.md that make pretty is required for test updates.#4045nlohmann merged 1 commit intonlohmann:developfrom
make pretty is required for test updates.#4045nlohmann merged 1 commit intonlohmann:developfrom
Conversation
Owner
|
Oof, Clang-Tidy again has some complaints... I'll check before merging this. |
Contributor
Author
|
The clang-tidy complaints are in files not touched by this PR. |
Owner
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add to CONTRIBUTING.md that
make prettyis required for test updates, as not doing so will result in a failure in the amalgamation check.Pull request checklist
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.