CMake: generate a pkg-config file that follow pkg-config conventions#4456
Merged
nlohmann merged 2 commits intonlohmann:developfrom Nov 26, 2024
Merged
CMake: generate a pkg-config file that follow pkg-config conventions#4456nlohmann merged 2 commits intonlohmann:developfrom
nlohmann merged 2 commits intonlohmann:developfrom
Conversation
And use @ replacement instead of {}, since ${} is significant in
pkg-config's format
This is more standard, and has some advantages when cross compiling. This also means that the pkg-config files generated by Meson and CMake now match.
Owner
|
Thanks! |
slowriot
pushed a commit
to slowriot/json
that referenced
this pull request
Jan 10, 2025
…lohmann#4456) * CMake: configure pkg-config with @only And use @ replacement instead of {}, since ${} is significant in pkg-config's format * CMake: use conventional prefix and incluedir variables in pkg-config This is more standard, and has some advantages when cross compiling. This also means that the pkg-config files generated by Meson and CMake now match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pkg-config file generated by Meson matches the convention of using a
prefixvariable, and anincludedirvariable that is relative toprefix(includedir=${prefix}/include). The one generated by CMake does not do this, but hard codes the include directory straight into theCflagsfield. There are advantages to having theprefix(thus the convention)`, especially when cross compiling.This PR makes the CMake generated pkg-config file meat convention, and match the one generated by Meson.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.