Another desperate try to fix the CI#4489
Conversation
fsandhei
left a comment
There was a problem hiding this comment.
Code-wise, I think it looks good! Can't say anything about the compiler supports.
Just one question: When disabling lints, do you have a norm to give a reasoning on why some lints are disabled? I find that it helps to have some comment next to the NOLINT statement to remind me when I inevitable forget why I disabled this lint.
Thanks!
Yes, I agree. There are 134 |
|
I merge this now. Good is better than perfect... |
* 🚨 fix warning * 💚 update actions * 🚨 fix warning * 🚨 fix warning * 🚨 fix warning * 💚 update actions * 💚 update actions * 🚨 fix warning * 🚨 fix warning * 💚 update actions * 🚨 fix warning * 💚 update actions * 💚 update actions * 💚 update actions * 🚨 fix warning * 🚨 fix warning * 🚨 fix warning * 🚨 fix warning * 💚 update actions * 💚 update actions * 🚨 fix warning * 💚 update actions * 💚 update actions * 💚 update actions * 💚 update actions * 💚 update actions
This PR fixes a lot of warnings from Clang-Tidy (or suppresses them in case of false positives). Furthermore, GitHub actions have been updated.
Details:
Clang-Tidy warnings
The following warnings are currently suppressed to have a green CI. They need to be addressed at some point:
Suppressed the following warnings:
Update GitHub actions
actions/upload-artifact@v4,actions/checkout@v4,github/codeql-action/init@v3,peaceiris/actions-gh-pages@v4macos-11image; the following Xcode versions are no longer tested in the CI: '11.7', '12.4', '12.5.1', '13.0'macos-13image to test Xcode versions '14.2', '14.3', '14.3.1', '15.0.1', '15.1', '15.2'macos-14image to test Xcode versions '15.3', '15.4'macos-15image to test Xcode versions '16.0', '16.1'json-ciimage as these versions are no longer work on the respectivegccimages (checkout fails)