Conversation
Contributor
|
I don't believe that it is worth trying to "fix" this. More details at #4087 (comment) |
2 tasks
Owner
Author
|
I forgot to also remove the previous fixes in the test cases and add a pragma. |
Contributor
|
Do we need to worry about someone building the tests with different warning flags? I would hope that we'd be able to say "the tests are built with exactly these flags". |
Owner
Author
In the end, I did not suppress the warning, but could fix it by completing the rule of five. |
slowriot
pushed a commit
to slowriot/json
that referenced
this pull request
Jan 10, 2025
* 🔧 remove warning suppression * 🚨 fix weak-vtables warning nlohmann#4087 * 🚨 suppress -Wweak-vtables warning * 🚨 suppress -Wweak-vtables warning * ✅ fix test * ✅ fix test * ✅ fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4087