Support BSON uint64 de/serialization#4590
Conversation
nlohmann
left a comment
There was a problem hiding this comment.
Isn't 0x11 a timestamp and not just a uint64 number? It may be the same on the wire, but maybe the documentation should mention that we do not parse timestamps into anything date-related.
Also, please check https://github.com/nlohmann/json/pull/4590/checks?check_run_id=35367015620 on how to sign-off your commits.
Signed-off-by: Michael Valladolid <mikevalladolid@gmail.com>
Please if the commit Treat 0x11 as uint64 and not timestamp specific is aligned with your suggestion. |
Signed-off-by: Michael Valladolid <mikevalladolid@gmail.com>
|
Thank you! |
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This implements support for BSON uint64 de/serialization.
#4535
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.Please don't
#ifdefs or other means.