Skip to content

Add regression test for #3810#4608

Merged
nlohmann merged 5 commits intodevelopfrom
regression-for-3810
Feb 15, 2025
Merged

Add regression test for #3810#4608
nlohmann merged 5 commits intodevelopfrom
regression-for-3810

Conversation

@nlohmann
Copy link
Owner

Issue #3810 was fixed by merging #4597. This PR adds a regression test.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 19, 2025
@coveralls
Copy link

coveralls commented Jan 19, 2025

Coverage Status

coverage: 99.186%. remained the same
when pulling feb18d7 on regression-for-3810
into f06604f on develop.

@nlohmann nlohmann removed this from the Release 3.11.4 milestone Jan 19, 2025
@nlohmann nlohmann marked this pull request as draft January 19, 2025 18:15
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann marked this pull request as ready for review January 23, 2025 08:27
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 23, 2025
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jan 23, 2025
@nlohmann nlohmann merged commit 0b6881a into develop Feb 15, 2025
129 checks passed
@nlohmann nlohmann deleted the regression-for-3810 branch February 15, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M review needed It would be great if someone could review the proposed changes. tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants