Skip to content

🐛 add missing header to input_adapters.hpp#4830

Merged
nlohmann merged 1 commit intonlohmann:developfrom
ddkilzer:include-streambuf-in-input_adapters.hpp
Jun 25, 2025
Merged

🐛 add missing header to input_adapters.hpp#4830
nlohmann merged 1 commit intonlohmann:developfrom
ddkilzer:include-streambuf-in-input_adapters.hpp

Conversation

@ddkilzer
Copy link
Contributor

While the WebKit project was in the process of adopting Swift (clang) modules, a build error occurred because json.hpp uses std::streambuf, but it doesn't include the <streambuf> header. (A dependent project included json.hpp, then WebKit included this project's header, which is how it was found.)

The fix is to add the missing header to input_adapters.hpp.

  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

Signed-off-by: David Kilzer <ddkilzer@apple.com>
@ddkilzer ddkilzer requested a review from nlohmann as a code owner June 24, 2025 22:15
@github-actions github-actions bot added the S label Jun 24, 2025
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.12.1 milestone Jun 25, 2025
@coveralls
Copy link

Coverage Status

coverage: 99.19%. remained the same
when pulling 4d7ba33 on ddkilzer:include-streambuf-in-input_adapters.hpp
into b451735 on nlohmann:develop.

@nlohmann nlohmann merged commit d70e46b into nlohmann:develop Jun 25, 2025
144 checks passed
@nlohmann
Copy link
Owner

Thanks!

@ddkilzer ddkilzer deleted the include-streambuf-in-input_adapters.hpp branch June 25, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants