Simplify module API#4840
Merged
nlohmann merged 4 commits intonlohmann:developfrom Aug 3, 2025
mikomikotaishi:develop
Merged
Conversation
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
|
This pull request has been marked as stale because it has had no activity for 30 days. While we won’t close it automatically, we encourage you to update or comment if it is still relevant. Keeping pull requests active and up-to-date helps us review and merge changes more efficiently. Thank you for your contributions! |
github-actions
bot
added
the
state: stale
Contributor
Author
|
@nlohmann Hi, could I get an update on this pull request? I originally submitted it before but had to re-make it. This pull request just addresses an oversight to the previous PR I made. |
nlohmann
added
please rebase
Owner
|
Can you please rebase it to have a green CI? |
Contributor
Author
|
OK, updating. |
Contributor
Author
|
@nlohmann The CI tests pass, is there anything else left to address? |
Owner
|
Thanks! |
aryanrahar
pushed a commit
to aryanrahar/json-add
that referenced
this pull request
Aug 7, 2025
* Simplify module API Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com> * Forgot missing newline Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com> --------- Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
aryanrahar
pushed a commit
to aryanrahar/json-add
that referenced
this pull request
Aug 7, 2025
* Simplify module API Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com> * Forgot missing newline Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com> --------- Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com> Signed-off-by: Aryan Rahar <aryanrahar1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make amalgamate.This pull request follows up with and addresses a previous pull request, #4799. Here we reduce the
usingstatements to non-templatedusingstatements as it is simpler and does not interfere with the original header API.