Conversation
|
I'm not sure what happened with CI. I didn't change the .hpp files, just the |
|
No worries - Travis is sometimes a bit buggy. I restarted the failed job. It should be fine. |
|
I think Travis is having a bad day. |
README.md
Outdated
|
|
||
| :beer: If you are using OS X and [Homebrew](http://brew.sh), just type `brew tap nlohmann/json` and `brew install nlohmann_json` and you're set. If you want the bleeding edge rather than the latest release, use `brew install nlohmann_json --HEAD`. | ||
|
|
||
| If you are using the Meson Build System, then add a file called `nlohmann_json.wrap` to a file to your `subprojects` directory with the following 4 lines: |
There was a problem hiding this comment.
I think this text is too long. It reads more than an advertisement for Meson than as a brief description how to use the library if you are using Meson. Compare this to the description of Homebrew above. As I never used Meson before, it's hard to judge what the "minimal" description should be though.
|
The commits that I made per your review only touched the README.md file, but Travis CI is still not working correctly, it seems. |
|
As I said, Travis is sometimes a bit buggy. |
|
Thanks! |
Although the use of this library is very convenient by just copying over the header to another project, this makes it easy for those who want to checkout a particular commit or the HEAD at the build time of their project when they use the Meson Build System.
It adds only 1 file (
meson.build), and some usage info in theREADME.mdfile.Meson is a C++ build system, like CMake, but simpler. It aims to cut down on the time spent working on build files, and the time spent compiling.