Potential fix for code scanning alert no. 3: DOM text reinterpreted as HTML#24
Draft
Potential fix for code scanning alert no. 3: DOM text reinterpreted as HTML#24
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates questionnaire validation message rendering to avoid injecting user/DOM-influenced strings as HTML, addressing code scanning alert #3 (DOM text reinterpreted as HTML / potential XSS).
Changes:
- Replaced
.html(...)with.text(...)for.dTipvalidation message writes. - Preserved “clear message” behavior by using
.text("")instead of.html("").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/nm-Team/WebSite/security/code-scanning/3
Use text insertion instead of HTML insertion for user/DOM-influenced strings.
Best fix in this snippet:
.html(...)with.text(...)for all.dTipmessage writes that are plain text..text("")instead of.html("").Specifically in
src/js/questionnaire.js, update the.dTipwrites at:No new imports or helper methods are needed. This preserves functionality (showing validation messages) while preventing HTML interpretation/XSS.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.