Skip to content

fix: use --preload= for bun compatibility#52

Open
Emeralddddd wants to merge 1 commit intonmhjklnm:masterfrom
Emeralddddd:fix/bun-preload-syntax
Open

fix: use --preload= for bun compatibility#52
Emeralddddd wants to merge 1 commit intonmhjklnm:masterfrom
Emeralddddd:fix/bun-preload-syntax

Conversation

@Emeralddddd
Copy link
Copy Markdown

Summary

  • Change --preload <path> to --preload=<path> (equals sign syntax) for both dns-guard and fingerprint-hook BUN_OPTIONS
  • Bun requires the = form; space-separated form silently fails to load preload scripts

Test plan

  • Verify dns-guard preload works with bun runtime
  • Verify fingerprint-hook preload works with bun runtime
  • Confirm no regression with node runtime (NODE_OPTIONS unchanged)

Bun requires --preload=<path> (equals sign) syntax; space-separated
form silently fails to load the preload script.
Copy link
Copy Markdown
Owner

@nmhjklnm nmhjklnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one blocking issue.

src/templates.sh changes the BUN_OPTIONS form from --preload <path> to --preload=<path>, but this does not appear to fix the actual problem. I tested both forms locally against Bun 1.1.29 using a compiled standalone executable (the scenario Bun documents for BUN_OPTIONS), and in both cases the preload script was still not loaded.

So the current PR changes syntax, but does not demonstrate that CAC hooks (cac-dns-guard.js / fingerprint-hook.js) will actually be injected in the Bun executable case.

Please add an end-to-end validation against a compiled Bun executable / real Claude binary before merging. Right now this looks like it changes the spelling without fixing the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants