PR related to the python binding of variable node radius of CurveNetworks #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @nmwsharp , sorry to bother. As I'm keep receiving notification from this PR, just out of curiosity: are you using it just as a PR for continuous development or all the additional code is related to this PR? |
Owner
|
@xarthurx yes actually :) I must have forgotten that this branch was originally from your commit when I started using it as development branch, my apologies for the notification spam! I'm going to merge it in in the next few days, so the endless notifications will be over soon. |
Owner
|
@xarthurx I'll move this over to a new PR to clean up the history. |
Author
|
Ha. No bother at all, and actually interesting to see the progress time to time.
Thanks for the answer.
…On 28 Dec 2023 at 04:50 +0800, Nicholas Sharp ***@***.***>, wrote:
Closed #27.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to the python binding of nmwsharp/polyscope#180