Fix level set shading #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome, thank you! I didn't actually pull this down to test, but it all looks sane to me. |
Owner
|
Do you have an image/gif of this feature that you could easily share here? If it's enabled in the GUI now I should probably add it to the docs, and an image would be nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two minor bugs in polyscope's marching tets implementation.
u_sliceVectorrather than the gradient of the scalar function. This works fine for slicing along planes, but for arbitrary scalar functionsu_sliceVectoris completely independent from the functionI fixed these bugs and enabled level set visualization in the GUI