Skip to content

correct error for badly closed tag #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
noahmorrison merged 1 commit into from
Jul 3, 2017
Merged

correct error for badly closed tag #21

noahmorrison merged 1 commit into from
Jul 3, 2017

Conversation

@samuelcolvin
Copy link
Contributor

@samuelcolvin samuelcolvin commented Jul 2, 2017

The test kind of explains it. Without a properly closed tag a ValueError is raised, not ChevronError.

@coveralls
Copy link

coveralls commented Jul 2, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling ff2be52 on samuelcolvin:fix--unclosed-tag-error into 2e4e666 on noahmorrison:master.

@samuelcolvin samuelcolvin force-pushed the fix--unclosed-tag-error branch from ff2be52 to 4e24d6e Compare July 2, 2017 10:50
@coveralls
Copy link

coveralls commented Jul 2, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4e24d6e on samuelcolvin:fix--unclosed-tag-error into 2e4e666 on noahmorrison:master.

@noahmorrison noahmorrison merged commit 3497a2d into noahmorrison:master Jul 3, 2017
@samuelcolvin samuelcolvin mentioned this pull request Jul 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samuelcolvin @coveralls @noahmorrison