Fix Py>=3.14 compat for WeakValueDictionary subclasses #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds Python 3.14 compatibility to the pydispatch library by addressing changes made to WeakValueDictionary in Python 3.14 (python/cpython#125325). The PR fixes issue #24 by manually reintroducing _pending_removals and _iterating attributes that were removed from the parent class, and updates asyncio examples to use modern patterns.
Key Changes
- Reorganized imports to move
_remove_dead_weakreffromweakrefto_weakrefmodule - Added manual initialization of
_pending_removalsand_iteratingattributes inWeakValueDictionarysubclasses for Python 3.14+ compatibility - Implemented conditional import and no-op fallback for
_IterationGuardwhich was removed in Python 3.14 - Updated documentation examples to use modern asyncio patterns (
asyncio.run(),get_running_loop(),create_task()) - Added Python 3.14 to CI/CD test matrix with conditional exclusion for sphinx-plugin
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pydispatch/utils.py | Reorganized imports and added manual initialization of _pending_removals and _iterating in InformativeWVDict for Python 3.14 compatibility |
| pydispatch/aioutils.py | Reorganized imports, added conditional _IterationGuard implementation, and manually initialized _pending_removals and _iterating in AioWeakMethodContainer |
| pydispatch/dispatch.py | Updated asyncio docstring example to use modern asyncio.run() and get_running_loop() patterns |
| doc/source/async.rst | Updated multiple asyncio examples to use modern patterns replacing deprecated get_event_loop() |
| .github/workflows/dist-test.yml | Added Python 3.14 to test matrix and conditionally excluded sphinx-plugin tests for 3.14 |
| .github/workflows/ci.yml | Added Python 3.14 to test matrix and conditionally excluded sphinx-plugin tests for 3.14 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in python/cpython#125325
Fixes #24