fix(auth): harden E2E bypass to reject production#56
Merged
Conversation
nocoo
force-pushed
the
fix/e2e-auth-bypass-guard
branch
2 times, most recently
from
12a6054 to
621b8c0
Compare
next start forces NODE_ENV=production, making NODE_ENV checks unreliable for E2E auth bypass. Replace with dual-key guard: both E2E_SKIP_AUTH=true AND E2E_TEST_RUNNER=true required. E2E_TEST_RUNNER is set exclusively by scripts/run-e2e.ts and will never appear in production deployments.
nocoo
force-pushed
the
fix/e2e-auth-bypass-guard
branch
from
621b8c0 to
cffdd19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51\n\n
isE2EMode()now unconditionally returnsfalsewhenNODE_ENV === production, preventing auth bypass even if E2E_SKIP_AUTH and CI env vars leak to production.\n\nSeverity: HIGH