Conversation
Read version from package.json instead of hardcoding ipsafe/1.0.2, preventing test failures when the version is bumped.
- Install husky and configure pre-commit hook to run tests + lint - Add CI workflow using nocoo/base-ci reusable workflow - CI triggers on push/PR to main and manual dispatch
- Add tests for getConfigPaths, getGlobalConfigPath, initGlobalConfig, showConfigInfo, checkContent, checkNetworkWithRetries, parseCommand - Add tests for content checking, timeout, and error paths in testConnectivity - Add tests for command timeout, exit cleanup, interactive commands - Add check-safe.js test suite for checkNetworkSafe and executeIfSafe - Add CLI (bin/ipsafe.js) test suite covering all flags and error paths - Configure jest coverage thresholds at 90% for statements/branches/functions/lines
- Update lint scripts to use --max-warnings=0 - Fix unused imports and variables in test files - Fix single-quote style violation in test
- Add .gitleaks.toml with allowlist for node_modules, coverage, lockfile - Add osv-scanner.toml for dependency vulnerability scanning
- Generate bun.lock from package-lock.json so `bun install --frozen-lockfile` works in the reusable bun-quality workflow - Pass osv-config to the reusable workflow so osv-scanner.toml is used
Add ignore entries for GHSA-xffm-g5w8-qvg7, GHSA-2g4f-4pwh-qvx6, GHSA-f886-m6hf-6m8v, GHSA-25h7-pfq9-p65f, GHSA-rf6f-7fwh-wjgh, and GHSA-mh29-5h37-fv8m covering vulnerabilities in transitive deps (@eslint/plugin-kit, ajv, brace-expansion, flatted, js-yaml).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds husky hooks, CI workflow, test coverage thresholds, strict lint, and G2 security configs.
6DQ compliance: L0+L1+G1+G2 → enables Tier B.