Function as target object allowed

src/weakref.cc

@@ -8,7 +8,7 @@ namespace {
 class ObjectInfo : public ObjectWrap<ObjectInfo> {
  public:
   ObjectInfo(const CallbackInfo& args) : ObjectWrap(args) {
-    if (!args[0].IsObject())
+    if (!args[0].IsObject() && !args[0].IsFunction())
       throw Error::New(Env(), "target should be object");
     if (!args[1].IsFunction())
       throw Error::New(Env(), "callback should be function");

test/create.js

@@ -14,10 +14,29 @@ describe('create()', function() {
       null,
       undefined,
       'foo',
+      Symbol(),
     ].forEach((val) => {
       assert.throws(function() {
         weak.create(val);
       });
     });
   });
+
+  it('should accept "object" values', function() {
+    [
+      {},
+      function() {},
+      () => {},
+      [],
+      Buffer(''),
+      new ArrayBuffer(10),
+      new Int32Array(new ArrayBuffer(12)),
+      Promise.resolve(),
+      new WeakMap(),
+    ].forEach((val) => {
+      assert.doesNotThrow(() => {
+        assert.ok(weak.create(val));
+      }, Error, String(val));
+    });
+  });
 });