use os.tmpdir() instead of os.tmpDir() #382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Ah, yes. This fails on Node.js 0.8, since |
gswalden
reviewed
Nov 17, 2016
| this.maxFieldsSize = opts.maxFieldsSize || 2 * 1024 * 1024; | ||
| this.keepExtensions = opts.keepExtensions || false; | ||
| this.uploadDir = opts.uploadDir || os.tmpDir(); | ||
| this.uploadDir = opts.uploadDir || os.tmpdir(); |
Contributor
There was a problem hiding this comment.
to fix the failed test, how about
this.uploadDir = opts.uploadDir || (os.tmpdir || os.tmpDir)();
Author
There was a problem hiding this comment.
@gswalden I'm pretty sure that Node.js 0.8 support can and should be dropped. I.e. not break on a purpose, but don't care about it specifically, so this doesn't need code complication.
Contributor
There was a problem hiding this comment.
Agreed, but I have no write access to this repo, just trying to usher this along.
Collaborator
|
See #412 |
Author
|
@felixge I don't use node-formidable, this issue was found during mass npm package scanning. |
Contributor
|
This is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#6739