This repository was archived by the owner on Nov 4, 2022. It is now read-only.
fix: check for editor in environment variables#748
Merged
protoEvangelion merged 4 commits intonode-gh:masterfrom Nov 25, 2019
Merged
fix: check for editor in environment variables#748protoEvangelion merged 4 commits intonode-gh:masterfrom
protoEvangelion merged 4 commits intonode-gh:masterfrom
Conversation
To determine which editor to use for commit messages look if $EDITOR or $VISUAL are set in the environment before checking the git config. If no editor is found throw an error. Fixes node-gh#745
Member
|
Just started reviewing :) |
Member
|
Hmm it's passing locally but not on CI. I'm looking into it now. |
protoEvangelion
suggested changes
Nov 24, 2019
Member
protoEvangelion
left a comment
protoEvangelion
left a comment
There was a problem hiding this comment.
Thanks for taking the initiative on this 🎉 Just gotta clean up that double ternary and figure out why the test is failing.
Member
|
🎉 This PR is included in version 2.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To determine which editor to use for commit messages
look if $EDITOR or $VISUAL are set in the environment
before checking the git config. If no editor is found
throw an error. Fixes #745