Skip to content

remove of deprected "new Buffer"#16

Merged
Sawtaytoes merged 1 commit into
node-lifx:masterfrom
mabels:new-buffer
Sep 23, 2019
Merged

remove of deprected "new Buffer"#16
Sawtaytoes merged 1 commit into
node-lifx:masterfrom
mabels:new-buffer

Conversation

@mabels
Copy link
Copy Markdown
Contributor

@mabels mabels commented Sep 23, 2019

Please integrated these first in preparation of the TileAPI.
This is only a cleanup of a deprecated api.

@Sawtaytoes
Copy link
Copy Markdown
Collaborator

Looks good to me!

@Sawtaytoes Sawtaytoes merged commit ad05c86 into node-lifx:master Sep 23, 2019
@Sawtaytoes
Copy link
Copy Markdown
Collaborator

I just realized we might want to ensure the minimum Node.js version is correct for this change.

@mabels
Copy link
Copy Markdown
Contributor Author

mabels commented Sep 24, 2019

I think we should skip it, it since:
https://nodejs.org/docs/latest-v4.x/api/buffer.html

@Sawtaytoes
Copy link
Copy Markdown
Collaborator

Sawtaytoes commented Sep 24, 2019

Perfect.
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants