Fix commonjs handling. #9
Conversation
There was a problem hiding this comment.
This project has git hooks that fix the code formatting via prettier during pre-commit. This is done via the husky package. Your changes here skipped the pre-commit hook, resulting in every line of code being changed. Additionally, you seemed to rewrite the entire project rather than just modifying it in the ways needed to implement the feature.
For this reason, I'm not going to review it until those items are fixed - please do not apply your own formatting to the code, but instead use the built in git hooks that run prettier automatically. If you're having trouble figuring out the git hooks, you can run pnpm run format and it will fix everything. Additionally, do not rewrite the parts of the project that do not need to be touched for your feature.
|
@joeldenning I ask for forgiveness. Please do not consider this PR for merging. I just meant it to be another reference implementation of #8. For comparison only. |
|
no problem, let's move discussion for this feature to #8 |
2 participants
Just for reference for #8, this is the implementation I am currently using. Fixes #7.