Skip to content

Conversation

@johnloy
Copy link
Contributor

@johnloy johnloy commented Feb 15, 2021

When specifying an absolute system path for NODE_LOADER_CONFIG, this change allows that path to be used, instead of joining it with process.cwd().

Tests ✅ after this change.

Copy link

@internettrans internettrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

The tests don't cover the NODE_LOADER_CONFIG env variable, I don't think, so them passing doesn't show that this entirely works. The code looks good, though, so I'll merge this and test locally before publishing a new version.

@internettrans internettrans merged commit 1921acb into node-loader:master Feb 15, 2021
@internettrans
Copy link

Ah this added a package-lock.json file, which it should not have. I will remove that in a subsequent commit.

@internettrans
Copy link

I fixed the issues with the lock files, among a couple other small maintenance things, in #3. Everything's released in https://github.com/node-loader/node-loader-core/releases/tag/v1.0.4

@johnloy
Copy link
Contributor Author

johnloy commented Feb 16, 2021

Thanks so much for the speedy release! Also, I appreciate your great work on this and your other import maps packages.

In case it's of interest, I'm using this and @node-loader/import-maps in https://github.com/johnloy/static-shadow-dom. I hope to be publishing within a few days, and will be sure to give you a README thanks there once I do.

If you'd like, I could also contribute a test for the env variable?

Cheers!

@internettrans
Copy link

Great to hear you are using this project in static-shadow-dom. Yes, if you'd like to add a test for the NODE_LOADER_CONFIG env variable that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants