Merged
Conversation
Author
|
@coolme200 这个 PR 是想保证 decode with type 之后能够按照这个再encode回去,与原来的数据保持一致。
上面的理解不知道有没有不对的地方?另外还有什么要考虑的地方需要完成,才能够实现 |
Author
|
@fengmk2 @dead-horse 都帮忙看一下哈,对协议不熟,感觉有盲点。 |
Author
There was a problem hiding this comment.
不过最关键的是上面我说的那个问题,有哪些信息 encode(decode(buffer)) 之后可能无法完全一致
fa8f0a8 to
0849080
Compare
0849080 to
48f263b
Compare
Author
|
神奇了,为什么 iojs-2 iojs-1 在 ci 下载不到。。 还有就是 string 那个老超时 |
.travis.yml
Outdated
6834f53 to
8b92e78
Compare
Author
8b92e78 to
4d3143a
Compare
Author
|
|
Member
|
先执行 nvm ls-remote,我都是直接写 1,2,3,4的https://github.com/node-modules/urllib/blob/master/.travis.yml#L6 |
4d3143a to
d9fa33a
Compare
…essing in node4 takes too long
Author
Member
|
WIP? 还是可以合并了? |
Author
|
忘记改了 可以合并了 |
fengmk2
added a commit
that referenced
this pull request
Oct 31, 2015
…-1.x Improve decode with type for 1.x
Member
|
hessian.js@1.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.