Skip to content

Improve decode with type for 1.x#52

Merged
fengmk2 merged 5 commits into1.xfrom
improve-decode-with-type-for-1.x
Oct 31, 2015
Merged

Improve decode with type for 1.x#52
fengmk2 merged 5 commits into1.xfrom
improve-decode-with-type-for-1.x

Conversation

@shaoshuai0102
Copy link
Copy Markdown

No description provided.

@shaoshuai0102 shaoshuai0102 changed the title Improve decode with type for 1.x [WIP]Improve decode with type for 1.x Oct 29, 2015
@shaoshuai0102
Copy link
Copy Markdown
Author

@coolme200 这个 PR 是想保证 decode with type 之后能够按照这个再encode回去,与原来的数据保持一致。

  • int, string, date 没有做,按道理应该没有问题。
  • map 的 decode with type 也没有做,这个要支持么?因为 java 的 map 中实际上是有 key 值是非 string 的,如果做的话需要 decode 成 js Map 对象,比较麻烦。而且 sessiontair 这次好像也用不到。

上面的理解不知道有没有不对的地方?另外还有什么要考虑的地方需要完成,才能够实现 encode(decode(buffer)) 与原来的 buffer 一样?

@shaoshuai0102
Copy link
Copy Markdown
Author

@fengmk2 @dead-horse 都帮忙看一下哈,对协议不熟,感觉有盲点。

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试用例里面没有对应的?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我补一下。

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不过最关键的是上面我说的那个问题,有哪些信息 encode(decode(buffer)) 之后可能无法完全一致

@shaoshuai0102 shaoshuai0102 force-pushed the improve-decode-with-type-for-1.x branch from fa8f0a8 to 0849080 Compare October 29, 2015 09:24
@shaoshuai0102 shaoshuai0102 force-pushed the improve-decode-with-type-for-1.x branch from 0849080 to 48f263b Compare October 29, 2015 09:41
@shaoshuai0102
Copy link
Copy Markdown
Author

神奇了,为什么 iojs-2 iojs-1 在 ci 下载不到。。

还有就是 string 那个老超时

.travis.yml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成 2 就 ok 了

@shaoshuai0102 shaoshuai0102 force-pushed the improve-decode-with-type-for-1.x branch from 6834f53 to 8b92e78 Compare October 29, 2015 15:39
@shaoshuai0102
Copy link
Copy Markdown
Author

image

还是不行。。

@shaoshuai0102 shaoshuai0102 force-pushed the improve-decode-with-type-for-1.x branch from 8b92e78 to 4d3143a Compare October 29, 2015 15:50
@shaoshuai0102
Copy link
Copy Markdown
Author

nvm install iojs-v2 也不行,醉了,travis 用的啥 nvm。。

@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Oct 29, 2015

先执行 nvm ls-remote,我都是直接写 1,2,3,4的https://github.com/node-modules/urllib/blob/master/.travis.yml#L6

@shaoshuai0102 shaoshuai0102 force-pushed the improve-decode-with-type-for-1.x branch from 4d3143a to d9fa33a Compare October 30, 2015 06:49
@shaoshuai0102
Copy link
Copy Markdown
Author

加了 sudo: false 就好了。

image

node 3 4 性能好差

@fengmk2 fengmk2 self-assigned this Oct 30, 2015
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Oct 30, 2015

WIP? 还是可以合并了?

@shaoshuai0102 shaoshuai0102 changed the title [WIP]Improve decode with type for 1.x Improve decode with type for 1.x Oct 30, 2015
@shaoshuai0102
Copy link
Copy Markdown
Author

忘记改了 可以合并了

fengmk2 added a commit that referenced this pull request Oct 31, 2015
@fengmk2 fengmk2 merged commit 129048c into 1.x Oct 31, 2015
@fengmk2 fengmk2 deleted the improve-decode-with-type-for-1.x branch October 31, 2015 01:33
@fengmk2
Copy link
Copy Markdown
Member

fengmk2 commented Oct 31, 2015

hessian.js@1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants