Feat required config #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 162 164 +2
Branches 56 57 +1
=====================================
+ Hits 162 164 +2
Continue to review full report at Codecov.
|
Author
|
The condition is when having a create and edit common interface , I may code like this: const schema = {
userId: {
type: 'int'
},
title: {
required: false,
type: 'string',
},
brief: {
required: false,
type: 'string',
},
content: {
required: false,
type: 'string',
},
xxx1: {
required: false,
type: 'string',
},
...
}
ctx.validate(schema, myParams); |
dead-horse
reviewed
Aug 8, 2018
index.js
Outdated
| this.validateRoot = true; | ||
| } | ||
| this.defaultRequired = opts.defaultRequired !== undefined ? | ||
| opts.defaultRequired : |
Member
There was a problem hiding this comment.
this.defaultRequired = opts.defaultRequired !== false;
dead-horse
reviewed
Aug 8, 2018
index.js
Outdated
| if (rule.required !== false) { | ||
| var required = rule.required !== undefined ? | ||
| rule.required : | ||
| this.defaultRequired; |
ycjcl868
force-pushed
the
feat-required-config
branch
from
698d819 to
85e257b
Compare
docs: options.defaultRequired
Member
|
rebase ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.