wrong typing for revokeToken argument

[jorenvandeweyer]

Specify your setup

• Operating System:
• Node version:
• npm version:
• version of @node-oauth/oauth2-server
• which OAuth2 workflow:
• at which workflow step does the error occur:

Describe the bug

Typescript type seems to be wrong for the revokeToken argument token

node-oauth2-server/index.d.ts

Line 371 in b9d4093

revokeToken(token: RefreshToken | Token, callback?: Callback<boolean>): Promise<boolean>;

Expected behavior

Should be only RefreshToken

[jankapunkt]

Hm, callback should also be not included but that was already fixed 🤔 Let me check, which branch contains the most recent docs right now

[jankapunkt]

Okay I found that types also still contain callback arguments, so we should definitely remove them for development and furthermore 5.x release

[shrihari-prakash]

@jankapunkt we already removed callbacks in 5.x I remember?

[jankapunkt]

@shrihari-prakash thanks for the reminder! @jorenvandeweyer in that case we only need to change the token param, the rest gets updated with merging #194 automatically

[shrihari-prakash]

#211

[jankapunkt]

@jorenvandeweyer @shrihari-prakash the types file still contains revokeToken instead of refreshToken in #194 . Should this be handled in #194 ? I mean, once it's released it will be "pinned" in this version and may cause confusion.

One more PR to fix this?

[jorenvandeweyer]

Yes, this should be fixed bedore releasing it

[shrihari-prakash]

@jankapunkt you mean we remove the Token and only have RefreshToken right?

[shrihari-prakash]

I have a doubt, why should it be refresh token? As I understand, the function also revokes access tokens?

[jorenvandeweyer]

The refresh token type is passed as argument not the access token type, where do you see the access token type being passed? @shrihari-prakash

[shrihari-prakash]

@jorenvandeweyer the type Token already contains both refresh and access tokens. The function revokeToken is used to clear both refresh and access tokens. I think it is rather correct that we remove type RefreshToken and keep type Token in the method revokeToken.

[shrihari-prakash]

I don't think there is a separate function to clear access tokens at the moment.

[shrihari-prakash]

Or on the flip side, we could also remove Token type from argument and add properties accessToken and accessTokenExpiresAt to the RefreshToken type. As you can see, there is nothing related to access tokens currently on that type: