PR #197 fix removed after merge

[mthlemos]

Specify your setup

• Operating System: macOS Sonoma 14.1
• Node version: 18.12.1
• npm version: Not applicable
• version of @node-oauth/oauth2-server: release-5.0.0 branch
• which OAuth2 workflow: Authorization Code
• at which workflow step does the error occur: Authorization Request

Describe the bug

PR #197 fix got removed after a merge commit.

More specifically this merge commit: 6758bff

To Reproduce

This bug is currently present on the release-5.0.0 branch.

node-oauth2-server/lib/handlers/authorize-handler.js

Line 370 in b97f6c7

return request.body.code_challenge;

node-oauth2-server/lib/handlers/authorize-handler.js

Line 381 in b97f6c7

const algorithm = request.body.code_challenge_method;

Expected behavior

Should also receive the code_challenge and code_challenge_method through the query params.

getCodeChallenge (request) {
  return request.body.code_challenge || request.query.code_challenge;
}

getCodeChallengeMethod (request) {
  const algorithm = request.body.code_challenge_method || request.query.code_challenge_method;
  ...
}

Additional context

None

[jankapunkt]

Thank you for reporting @mthlemos I will try to cherry pick this one and create a new RC (which is still pending since I was on vacation)

[jankapunkt]

@mthlemos added this again in https://github.com/node-oauth/node-oauth2-server/releases/tag/v5.0.0-rc.5 feel free to reopen if the issue persists in rc5

[mthlemos]

Thank you very much for the quick fix @jankapunkt!