Update extension-grants.rst with example#92
Merged
jankapunkt merged 5 commits intonode-oauth:release-4.2.0from Mar 30, 2022
Merged
Update extension-grants.rst with example#92jankapunkt merged 5 commits intonode-oauth:release-4.2.0from
jankapunkt merged 5 commits intonode-oauth:release-4.2.0from
Conversation
33 tasks
jankapunkt
changed the title
33 tasks
jankapunkt
requested review from
HappyZombies,
Uzlopak,
jorenvandeweyer and
jwerre
Member
|
Can someone else review this, I am not using the rst files |
jorenvandeweyer
previously approved these changes
Jan 13, 2022
Member
jorenvandeweyer
left a comment
jorenvandeweyer
left a comment
There was a problem hiding this comment.
Looks fine, but can we merge it without the changes to CHANGELOG.md, package.json and package-lock.json?
Contributor
Author
|
Hi, reverted the changes on Regards |
Member
|
@Uzlopak @HappyZombies @jorenvandeweyer should we include this in 4.2.0 ? |
Uzlopak
previously approved these changes
Mar 29, 2022
Collaborator
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
I think it is ok so far.
Member
|
Yes it's ok so far and I'll put it for 4.2.0 @FStefanni , please update the typo and we can merge it |
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
Contributor
Author
|
Done :) |
jankapunkt
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
just updated a doc example, which seems fine to me.
I have left classes on purpose, since it is a more modern JS syntax, and probably also this code base is moving to more modern JS.
Regards.
Edit by @jankapunkt: Fixed issue 89, point 5, original issue 530