Node 0.5.x compatibility for Binding Require and removed Headers #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld/Release. Remove ev.h and node_events.h imports
Author
|
Closing Pull Request, Pull Request #41 will satisfy this and more! |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in jgoulah's pull request #34, there are some headers removed in node 0.5.x+ that were unused in pcap_binding.cc. An additional header, ev.h was removed.
Also, directory where bindings are compiled has been moved from ./build/default to ./build/Release, added a try catch block to attempt to import from ./build/default, if that fails, attempts ./build/Release (what node 0.5.x+ is now using).