Skip to content

Conversation

@DanCunnington
Copy link
Contributor

@DanCunnington DanCunnington commented Nov 8, 2016

Fix for #38

Summary

Known Issues

  • Charts render incorrectly when data points fall outside a specified range. Issue raised against Chart.js and failing test case created outside of Node-RED.
  • The last x Axis label can sometimes overlap. Outstanding PR on Chart.js to fix this issue.
  • Colours are manually specified - this may change when the theme chooser is implemented.

Note. This is a revised version of #89 to account for limiting the number of points as discussed in #38. This PR is ready for review.

@dceejay dceejay merged commit e685c39 into node-red:newchart Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants