Skip to content

Conversation

@kazuhitoyokoi
Copy link
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Current node generator generates package.json file which has four spaces as indent. npm init command generates package.json file whose indent size is two spaces. Therefore, all lines will be changed when npm init command modifies package.json file generated from node generator. To solve the problem, I changed indent size in package.json templates.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.607% when pulling 85c011a on kazuhitoyokoi:master-updatepackagejson into d174103 on node-red:master.

@HiroyasuNishiyama HiroyasuNishiyama merged commit 7841dfe into node-red:master Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants