Skip to content

Conversation

@natcl
Copy link
Contributor

@natcl natcl commented Apr 23, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

The node-red-node-physical-web node has been broken for years following this abandonment of noble and bleno, this is updated with newer packages from @abndonware.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.153% when pulling 7b21ac4 on natcl:newPhysicalWeb into 2464637 on node-red:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.153% when pulling 7b21ac4 on natcl:newPhysicalWeb into 2464637 on node-red:master.

@hardillb hardillb merged commit 263031d into node-red:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants