Problems with more than one MCP3008 #823
Conversation
dceejay
left a comment
dceejay
left a comment
There was a problem hiding this comment.
Couple of tiny questions to fix but yes basically good...
hardware/mcp3008/pimcp3008.js
Outdated
| module.exports = function(RED) { | ||
| "use strict"; | ||
| var fs = require('fs'); | ||
| var fs2 = require('fs'); |
There was a problem hiding this comment.
Not sure why we need this duplication ?
There was a problem hiding this comment.
This is a holdover from debugging.
The line can remain original
hardware/mcp3008/pimcp3008.js
Outdated
| // unlikely if not on a Pi | ||
| try { | ||
| var cpuinfo = fs.readFileSync("/proc/cpuinfo").toString(); | ||
| var cpuinfo = fs2.readFileSync("/proc/cpuinfo").toString(); |
There was a problem hiding this comment.
Likewise - why won't the original be ok ?
There was a problem hiding this comment.
The line can remain also original.
hardware/mcp3008/pimcp3008.js
Outdated
| this.dnum = parseInt(n.dnum || 0); | ||
| this.bus = parseInt(n.bus || 0); | ||
| this.dev = n.dev || "3008"; | ||
| this.fs = require('fs'); |
There was a problem hiding this comment.
Here I was not shure if the definition from the global place caused any problems. So I createt a new one and renamed the orginal to fs2.
If you want to remove the line you have also edit line 42.
from:
this.fs.statSync("/dev/spidev"+node.bus+"."+node.dnum);
to:
fs.statSync("/dev/spidev"+node.bus+"."+node.dnum);
I testet this on my raspberry and it worked
implementation of the discussion
|
|
/easycla |
2 participants
Proposed changes
It was only possible to communicate with one MCP3008 at once.
Now several MCPs can be used at the same time.
Checklist
gruntto verify the unit tests pass