add space:Storage #1632
Merged
add space:Storage #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
Co-authored-by: Timea <timea.turdean@gmail.com>
angelo-v
previously requested changes
Oct 31, 2021
Contributor
angelo-v
left a comment
angelo-v
left a comment
There was a problem hiding this comment.
Please add unit tests, at least for the code you added.
angelo-v
reviewed
Oct 31, 2021
csarven
previously requested changes
Nov 1, 2021
Co-authored-by: Sarven Capadisli <info@csarven.ca>
Co-authored-by: Sarven Capadisli <info@csarven.ca>
Co-authored-by: Sarven Capadisli <info@csarven.ca>
kjetilk
approved these changes
Nov 1, 2021
Member
kjetilk
left a comment
kjetilk
left a comment
There was a problem hiding this comment.
This looks good to me now. However, it has been so long since I was into the details of NSS that it should probably receive more than my review :-)
bourgeoa
dismissed stale reviews from csarven and angelo-v
comments already commited
angelo-v
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add space:Storage to headers and podRoot 'text/turtle' container representation
see issue #1629