Skip to content

Conversation

@bourgeoa
Copy link
Member

@bourgeoa bourgeoa commented Aug 3, 2022

No description provided.

bourgeoa and others added 3 commits August 19, 2022 18:43
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@bourgeoa bourgeoa self-assigned this Aug 19, 2022
@bourgeoa bourgeoa linked an issue Aug 19, 2022 that may be closed by this pull request
@bourgeoa bourgeoa changed the title Patch jsonld Patch jsonld, rdf and n3 Aug 20, 2022
@bourgeoa bourgeoa changed the title Patch jsonld, rdf and n3 PATCH jsonld, rdf and n3 Aug 20, 2022
@bourgeoa bourgeoa changed the title PATCH jsonld, rdf and n3 PATCH jsonld, rdf+xml and n3 Aug 20, 2022
@bourgeoa
Copy link
Member Author

Should XML+RDF be spec compliant. rdfA is not ???
This questioned the default in case of new file in mashlib.
Creating a .rdf resource succeed but display a parse error.

@jeff-zucker
Copy link
Member

Should XML+RDF be spec compliant. rdfA is not ??? This questioned the default in case of new file in mashlib. Creating a .rdf resource succeed but display a parse error.

Are you talking specifically about the content type of the file being PATCHed? I sincerely hope that in the future RDFa will be patchable but that's a big task and not in the spec (yet) so no, I don't think we can offer to support it now. The simple case of creating a new RDFa file with PATCH could easily work but it does not make sense to me to support it if none of the other operations can work. As for XML+RDF - I am not familiar enough with parsing it to know for sure, but it seems to me that there would be no special issues for PATCH and therefore should be supported.

@jeff-zucker
Copy link
Member

^^ By which I mean that we should support sending a text/n3 PATCh to change an xml+rdf document, not that we should support sending an xml+rdf PATCH.

@bourgeoa bourgeoa added the bug label Aug 21, 2022
@timea-solid
Copy link
Contributor

I feel out of my depth to review this.

Copy link
Member

@michielbdejong michielbdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it! In the long run we should actually also have a test for this in the test suite probably - created solid-contrib/test-suite#148 about that

@bourgeoa bourgeoa merged commit 2e4ce40 into main Aug 22, 2022
@bourgeoa bourgeoa deleted the patchJsonld branch August 22, 2022 09:45
@bourgeoa bourgeoa mentioned this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PATCH does not work on JSON-LD file

6 participants