-
Notifications
You must be signed in to change notification settings - Fork 304
using node mailer as email service #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7fc22fd
using node mailer as email service
nicola 1357116
update to node v6 and adding email
nicola d2ec595
adding initial test for email
nicola f893bc4
removing extra semicolons
nicola f482c6f
adding command line for email
nicola c7af9d8
adding support to email flags
nicola 30c4d65
fixing the error in start
nicola f54a96c
removing extra space
nicola ccb50d9
adding resolving path of root
nicola cb7dd2e
do not start email if argvs not passed
nicola b94b36e
adding email helper in README
nicola File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| sudo: false | ||
| language: node_js | ||
| node_js: | ||
| - "4.0" | ||
| - "5.0" | ||
| - "6.0" | ||
|
|
||
| cache: | ||
| directories: | ||
| - node_modules | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| 'use strict' | ||
|
|
||
| const nodemailer = require('nodemailer') | ||
| const extend = require('extend') | ||
|
|
||
| class EmailService { | ||
| constructor (settings = {}) { | ||
| // This reflects nodemailer string option, we allow it | ||
| if (typeof settings !== 'string') { | ||
| settings = extend(settings, {secure: true}) | ||
| } | ||
| this.mailer = nodemailer.createTransport(settings) | ||
|
|
||
| if (settings.sender) { | ||
| this.sender = settings.sender | ||
| } else if (settings.host) { | ||
| this.sender = `no-reply@${settings.host}` | ||
| } | ||
| } | ||
| sendMail (email, callback) { | ||
| this.mailer.sendMail(email, callback) | ||
| } | ||
| } | ||
|
|
||
| module.exports = EmailService |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| const EmailService = require('../lib/email-service') | ||
| const sinon = require('sinon') | ||
| const expect = require('chai').expect | ||
|
|
||
| describe('Email Service', function () { | ||
| let email, transport | ||
|
|
||
| beforeEach(() => { | ||
| transport = { | ||
| name: 'testsend', | ||
| version: '1', | ||
| send: function (data, callback) { | ||
| callback() | ||
| }, | ||
| logger: false | ||
| } | ||
| email = new EmailService(transport) | ||
| }) | ||
|
|
||
| it('should send emails', (done) => { | ||
| sinon.stub(transport, 'send').yields(null, 'bep bop') | ||
|
|
||
| email.sendMail({ | ||
| subject: 'test' | ||
| }, function (err, info) { | ||
| expect(err).to.not.exist | ||
| expect(info).to.equal('bep bop') | ||
| done() | ||
| }) | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why Gmail is listed here, instead of plain SMTP config? It only makes sense if there was a different way of using the mailer with Gmail.