Accounts API v1 #339
Merged
Accounts API v1 #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2016
Closed
lib/api/accounts/signin.js
Outdated
|
|
||
| request({ method: 'OPTIONS', uri: req.body.webid }, function (err, req) { | ||
| if (err) { | ||
| res.status(406).send('Did not find a valid endpoint') |
Contributor
There was a problem hiding this comment.
Why 406 here? I thought that error only dealt with Accept headers & content types?
Contributor
Author
There was a problem hiding this comment.
if you send a bad URI, you should know about it
Contributor
There was a problem hiding this comment.
I agree. But this should be a 400 error, not 406.
Contributor
Author
There was a problem hiding this comment.
even for the 409 happening later?
Contributor
|
+1 from me, looks good. |
* implementing OIDC for new account creation * adding create user call in new * oidc in new * client is under .client * adding password
dmitrizagidulin
force-pushed
the
sign-in-out
branch
from
c064732 to
81778a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of APIs we are planning on implementing
v1
LDNODE
/api/accounts/signin: 302 to oidc if possible/api/accounts/signout: removes the session/api/accounts/recover: generates a token and contacts the user sending the token/api/accounts/validateToken: user can claim a token, gets the cookies and gets redirected to //api/accounts/new: creates a new account on LDP and create it under OIDC implementing OIDC for new account creation #349OIDC integration
/api/accounts/signin/api/accounts/new: call to OIDC to create new user implementing OIDC for new account creation #349for v2 see #350
Other things to do:
/api