Skip to content

Display git commit info when available. #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RubenVerborgh merged 1 commit into from
Sep 5, 2017
Merged

Display git commit info when available. #581

RubenVerborgh merged 1 commit into from
Sep 5, 2017

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Sep 5, 2017

Example:

$ bin/solid start
Solid server (v3.5.3-188-g7b63de0) running on https://localhost:8443/

Closes #580.

@RubenVerborgh RubenVerborgh added this to the 4.0.0 milestone Sep 5, 2017
@RubenVerborgh RubenVerborgh requested a review from timbl September 5, 2017 18:37
@RubenVerborgh RubenVerborgh mentioned this pull request Sep 5, 2017
Closed
timbl
timbl approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I think that save a lot of time and bring some clarity to getting this thing working

@RubenVerborgh RubenVerborgh merged commit d771b94 into release/v4.0.0 Sep 5, 2017
@RubenVerborgh RubenVerborgh deleted the feature/log-git-info branch September 5, 2017 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timbl timbl timbl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement ready for review

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@RubenVerborgh @timbl