Add popup for databrowser #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2017
Contributor
Author
|
This depends on the publication of mashlib with solid-auth-client 1.0.0 (through solid-ui), which @dan-f is working on. Popup will need a regeneration for minor issues. I did not find how to trigger the generated popup HTML from mashlib, so any help would be appreciated. |
This was referenced Sep 14, 2017
Contributor
|
@RubenVerborgh - I can show you how to trigger the login. Easier to explain in person than over GH comments. |
Closes #590.
RubenVerborgh
force-pushed
the
feature/popup
branch
from
ee7a495 to
11d4426
Compare
Contributor
Author
Closes #583.
RubenVerborgh
force-pushed
the
feature/popup
branch
from
11d4426 to
f79f7a2
Compare
Contributor
|
Popup needs to be templated with the name of the app (Solid Home?) |
tomasklapka
reviewed
Sep 17, 2017
| UI.authn.checkUser() | ||
| .then(function () { | ||
| var uri = window.location.href | ||
| var dataUri = window.document.title = uri.slice(0, uri.lastIndexOf('/')+1) + '' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #590.