Fix .acl lookup for paths with spaces #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
added
bug
priority-high
This was referenced May 3, 2018
timbl
approved these changes
May 3, 2018
Contributor
timbl
left a comment
timbl
left a comment
There was a problem hiding this comment.
Looks good and seems to work for me
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #656, we found that looking up
.aclfiles breaks when the path contains spaces. The root cause is that the translation code from URLs to filenames is duplicated all over the codebase, and sometimes implemented incorrectly—as apparently was the case for ACLs.This pull request does the following:
LegacyResourceMapper, which implements the URL to filename mapping that is currently used in v4.x, and now incorporates an URL encoding fix..acllookup component, such that it now properly decodes percent escapes.The
LegacyResourceMapperextends the newResourceMapperintroduced in #643, which captures the future URL to filename mapping. This new mapper has not been wired up yet, since it breaks compatibility and needs to be part of the 5.x release.In the future, we want to wire up this
LegacyResourceMapperto get rid of the error-prone inline mapping code (#661), which will allow us to transition easily to the newResourceMapper(#662).