Skip to content

Remove solid:inbox. #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RubenVerborgh merged 1 commit into from
Oct 25, 2018
Merged

Remove solid:inbox. #794

RubenVerborgh merged 1 commit into from
Oct 25, 2018

Conversation

@RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Sep 28, 2018

@RubenVerborgh RubenVerborgh added this to the 5.0.0 milestone Sep 28, 2018
@RubenVerborgh RubenVerborgh mentioned this pull request Sep 28, 2018
Closed
5 tasks
@kjetilk
Copy link
Member

kjetilk commented Sep 30, 2018

This is something that should probably go into the v5.0.0 branch?

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Sep 30, 2018

@kjetilk Good pointt.

@RubenVerborgh RubenVerborgh added the semver-major Involves breaking API changes label Sep 30, 2018
@RubenVerborgh RubenVerborgh changed the base branch from develop to release/v5.0.0 September 30, 2018 18:53
@melvincarvalho
Copy link
Contributor

melvincarvalho commented Oct 24, 2018

Just FYI: it's been on my todo list for ages, to add solid : inbox back to the vocabulary only.

It was removed by mistake, before we had a process of pull requests and review.

@csarven
Copy link
Member

csarven commented Oct 24, 2018

It wasn't removed by mistake, ldp:inbox replaces it. LDN standardises the notification system.

@melvincarvalho
Copy link
Contributor

melvincarvalho commented Oct 24, 2018

@csarven thanks for sharing your view. However, this is a discussion for the vocab repo.

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Oct 25, 2018 •
edited
Loading

As discussed in https://github.com/solid/vocab/issue/31 and solid/vocab#33, it's ldp:inbox now. Rebasing and merging.

@kjetilk kjetilk removed the on-hold label Oct 25, 2018
@RubenVerborgh RubenVerborgh merged commit 100b156 into release/v5.0.0 Oct 25, 2018
@RubenVerborgh RubenVerborgh deleted the fix/ldp-inbox branch October 25, 2018 13:08
@kjetilk kjetilk mentioned this pull request Dec 11, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melvincarvalho melvincarvalho Awaiting requested review from melvincarvalho

Assignees

@RubenVerborgh RubenVerborgh

Labels

bug ready for review semver-major Involves breaking API changes

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@RubenVerborgh @kjetilk @melvincarvalho @csarven