-
-
Notifications
You must be signed in to change notification settings - Fork 59
fix: Remove jniLibs.srcDirs #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Interesting, I also have 0.64.2 and I didn't have to make this change. Is it related to #1 ? |
|
Shouldn't be, that code doesn't touch anything related. I'll check a repro with an empty repo later this week. |
|
Hi, I think I'm having the same problem with jniLibs. I'm using react native 0.64.2. I'm reporting below the error from android studio about nodejs-mobile-react-native:
|
|
Yeah, I stumbled upon the need for this patch too. It's caused by updating Android Build Tools to version 4. Read the details here: https://developer.android.com/studio/releases/gradle-plugin#cmake-imported-targets |
I needed to make this change to get this to build on RN 0.64 due to changes in Gradle, which I think automatically adds these dirs? I don't really understand what this change does however, just that it made it work for me!