Skip to content

doc: update release dates #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BethGriggs merged 7 commits into from
Apr 16, 2019
Merged

doc: update release dates #434

BethGriggs merged 7 commits into from
Apr 16, 2019

Conversation

@BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Apr 12, 2019

No description provided.

@BethGriggs
Copy link
Member Author

BethGriggs commented Apr 12, 2019 •
edited
Loading

@nodejs/release PTAL at the estimated dates for the next few releases. Also, could someone please link me to the tool that generates the timeline image?

Refs: #431 /cc @sam-github

@jasonkarns, I've set the schedule.json to put v11.x into "maintenance" on 2019-04-22, and v12.x to start on 2019-04-23. Does this work?

@richardlau
Copy link
Member

richardlau commented Apr 12, 2019

Also, could someone please link me to the tool that generates the timeline image?

@BethGriggs https://github.com/nodejs/lts-schedule, See also #380 (comment).

targos
targos approved these changes Apr 12, 2019
View reviewed changes
@targos @BethGriggs
fixup: extend v13.x maintenance to remove "current" gap
3861b93 
Co-Authored-By: BethGriggs <bethany.griggs@uk.ibm.com>
MylesBorins
MylesBorins approved these changes Apr 12, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins
MylesBorins reviewed Apr 12, 2019
View reviewed changes
schedule.json
"lts": "2019-10-22",
"maintenance": "2021-04-01",
"end": "2022-04-01",
"codename": ""
Copy link
Contributor

@MylesBorins MylesBorins Apr 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to keep the codename here?

Suggested change
"codename": ""
"codename": "TBD"

mhdawson
mhdawson approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonkarns
Copy link
Member

jasonkarns commented Apr 13, 2019

I've set the schedule.json to put v11.x into "maintenance" on 2019-04-22, and v12.x to start on 2019-04-23. Does this work

@BethGriggs that's perfect, thanks!

@BethGriggs
Copy link
Member Author

BethGriggs commented Apr 15, 2019

Screenshot 2019-04-15 at 16 42 51

@nodejs/release, I have updated the timeline SVG - does this look ok?

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 15, 2019

LGTM

@BethGriggs BethGriggs merged commit f4ae92f into nodejs:master Apr 16, 2019
@BethGriggs BethGriggs mentioned this pull request Apr 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

+2 more reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BethGriggs @richardlau @jasonkarns @MylesBorins @jasnell @targos @mhdawson