update NODE_VERSION choices for nodereport-continuous-integration

[richardlau]

Current choices for NODE_VERSION in https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/ are:

• v9.0.0-nightly
• v4
• v5
• v6
• v7
• v8

This issue tracks the following changes:

• Add v10
• Replace v9.0.0-nightly with v11.0.0-nightly

Note that currently node-report is reported broken on Windows after the recent libuv update in v10.7.0 and master (i.e. the v11.0.0 nightlies): nodejs/node-report#113

[richardlau]

I believe that I have permissions to save changes to the config for this job (that is, the Save and Apply buttons appear).

[richardlau]

Config updated: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/jobConfigHistory/showDiffFiles?timestamp1=2017-09-15_10-39-11&timestamp2=2018-07-30_21-38-10

Running some jobs to test.

[richardlau]

Started https://ci.nodejs.org/job/nodereport-continuous-integration/215/ against Node.js v10. Apart from the expected Windows failures, the following are also failing:

nodereport-continuous-integration » rhel72-s390x completed with result FAILURE
nodereport-continuous-integration » smartos16-64 completed with result FAILURE
nodereport-continuous-integration » ubuntu1404-32 completed with result FAILURE
nodereport-continuous-integration » smartos15-64 completed with result FAILURE
nodereport-continuous-integration » ppcbe-ubuntu1404 completed with result FAILURE
nodereport-continuous-integration » smartos14-64 completed with result FAILURE

I think we need to update the job to be smarter about what platforms to build on. The current job config is using this wonderfully convoluted combination filter:
(MACHINES=="all" || MACHINES.contains(MACHINE)) && !((NODE_VERSION=="v4" || NODE_VERSION=="v5") && (MACHINE.contains("s390") || MACHINE.contains("aix"))) && !((NODE_VERSION=="v6" || NODE_VERSION=="v7") && (MACHINE.contains("smartos15") || MACHINE.contains("smartos16"))) && !((NODE_VERSION.contains("v8")) && (MACHINE.contains("smartos14")))

Maybe this can be replaced with jenkins/scripts/VersionSelectorScript.groovy?

The job may also need to call jenkins/scripts/select-compiler.sh.

[richardlau]

For v11.0.0-nightly: https://ci.nodejs.org/job/nodereport-continuous-integration/216/
Broken everywhere because headers are missing, probably due to #1409 (comment).

[refack]

Headers issue should now be resolved https://nodejs.org/download/nightly/v11.0.0-nightly20180731be322bd9ad/?d=10
(?d=10 added to bust the cache, so we need to wait for cache refresh or for tomorrow's job before re-testing )

[refack]

https://ci.nodejs.org/job/nodereport-continuous-integration/217/ now has a varity of actual failures. One that is build related is v10-11 do not include linux-32 binaries.

build/jenkins/scripts/VersionSelectorScript.groovy

Line 19 in dc56ae8

[ /centos6-32-gcc6/, releaseType, gte(10) ], // 32-bit linux for <10 only

[richardlau]

Update: I'm still looking at this. It looks like there's quite a bit of refactoring I would need to do to the job in terms of parameter/matrix names to be able to use the VersionSelectorScript.

• Add NODEJS_MAJOR_VERSION parameter (maybe refactor the existing NODE_VERSION parameter).

  build/jenkins/scripts/VersionSelectorScript.groovy

  Lines 85 to 87 in 4c5c10b

  	int nodeMajorVersion = -1
  	if (parameters['NODEJS_MAJOR_VERSION'])
  	nodeMajorVersion = parameters['NODEJS_MAJOR_VERSION'].toString().toInteger()

• Refactor MACHINE axis to nodes

  build/jenkins/scripts/VersionSelectorScript.groovy

  Lines 91 to 93 in 4c5c10b

  	// NOTE: this assumes that the default "Slaves"->"Name" in the Configuration
  	// Matrix is left as "nodes", if it's changed then `it.nodes` below won't work
  	// and returning a result with a "nodes" property won't work.

• Define a buildType, non-release (node-report?).

  build/jenkins/scripts/VersionSelectorScript.groovy

  Lines 96 to 97 in 4c5c10b

  	// Before running this script, `def buildType = 'release'` or some other value
  	// to be able to use the appropriate `buildType` in the exclusions

[mhdawson]

You might look at the job for https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api/. It most likely needs to run on the same set of Node version/os version combinations.

[richardlau]

Hmm tried to use VersionSelectorScript but getting a permissions error:
e.g. https://ci.nodejs.org/job/nodereport-continuous-integration/226/console

FATAL: script not yet approved for use
org.jenkinsci.plugins.scriptsecurity.scripts.UnapprovedUsageException: script not yet approved for use
	at org.jenkinsci.plugins.scriptsecurity.scripts.ScriptApproval.using(ScriptApproval.java:466)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScript.evaluate(SecureGroovyScript.java:343)
	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScript$evaluate.call(Unknown Source)
	at org.jenkinsci.plugins.ScriptRunner.run(ScriptRunner.groovy:71)
	at org.jenkinsci.plugins.ScriptRunner$run.call(Unknown Source)
	at org.jenkinsci.plugins.GroovyScriptMES.decideOrder(GroovyScriptMES.groovy:62)
	at org.jenkinsci.plugins.GroovyScriptMES$decideOrder.callCurrent(Unknown Source)
	at org.jenkinsci.plugins.BaseMES.run(BaseMES.groovy:51)
	at hudson.matrix.MatrixBuild$MatrixBuildExecution.doRun(MatrixBuild.java:375)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:504)
	at hudson.model.Run.execute(Run.java:1798)
	at hudson.matrix.MatrixBuild.run(MatrixBuild.java:323)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)

[richardlau]

Thanks to @refack for sorting the permissions.

[richardlau]

With Node 10: https://ci.nodejs.org/job/nodereport-continuous-integration/228/

rhel72-s390x failed to run node

+ node -v
node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by node)

smartos16-64 failed to run node

+ node -v
ld.so.1: node: fatal: relocation error: file /home/iojs/build/workspace/nodereport-continuous-integration/nodes/smartos16-64/node-v10.9.0-sunos-x64/bin/node: symbol _ZTVNSt7__cxx1119basic_ostringstreamIcSt11char_traitsIcESaIcEEE: referenced symbol not found
/var/tmp/jenkins4379535167751811945.sh: line 17: 82192: Killed

ubuntu1404-32 not skipped (probably an issue for the VersionSelectorScript).
Windows failures are expected (nodejs/node-report#113).

[richardlau]

Node.js v11.0.0-nightly failed due to missing headers tarball (and missing mac os binaries): https://ci.nodejs.org/job/nodereport-continuous-integration/230/