ansible: test-joyent-smartos*-x64-[34] #2014

sam-github · 2019-10-28T17:40:32Z

No description provided.

sam-github · 2019-10-28T17:43:07Z

@mhdawson @rvagg This is related to #2005 (comment)

I'd like to link this to some issue that describes why we are doing this but haven't found one.

mhdawson

LGTM

sam-github · 2019-10-28T18:26:51Z

TASK [baselayout : ccache : prepare for compilation] **********************************
fatal: [test-joyent-smartos15-x64-3]: FAILED! => {"changed": true, "cmd": "./configure -q", "delta": "0:00:02.227336", "end": "2019-10-28 17:43:41.943024", "msg": "non-zero r
eturn code", "rc": 1, "start": "2019-10-28 17:43:39.715688", "stderr": "configure: error: in `/tmp/ccache-3.6':\nconfigure: error: cannot run C compiled programs.\nIf you mea
nt to cross compile, use `--host'.\nSee `config.log' for more details", "stderr_lines": ["configure: error: in `/tmp/ccache-3.6':", "configure: error: cannot run C compiled p
rograms.", "If you meant to cross compile, use `--host'.", "See `config.log' for more details"], "stdout": "", "stdout_lines": []}                                           
fatal: [test-joyent-smartos15-x64-4]: FAILED! => {"changed": true, "cmd": "./configure -q", "delta": "0:00:02.315163", "end": "2019-10-28 17:43:42.105257", "msg": "non-zero r
eturn code", "rc": 1, "start": "2019-10-28 17:43:39.790094", "stderr": "configure: error: in `/tmp/ccache-3.6':\nconfigure: error: cannot run C compiled programs.\nIf you mea
nt to cross compile, use `--host'.\nSee `config.log' for more details", "stderr_lines": ["configure: error: in `/tmp/ccache-3.6':", "configure: error: cannot run C compiled p
rograms.", "If you meant to cross compile, use `--host'.", "See `config.log' for more details"], "stdout": "", "stdout_lines": []}                                           
changed: [test-joyent-smartos17-x64-4]
changed: [test-joyent-smartos17-x64-3]

TASK [baselayout : ccache : compile] **************************************************
fatal: [test-joyent-smartos17-x64-4]: FAILED! => {"changed": false, "cmd": "/opt/local/bin/gmake", "msg": "gmake: *** No targets specified and no makefile found.  Stop.", "rc
": 2, "stderr": "gmake: *** No targets specified and no makefile found.  Stop.\n", "stderr_lines": ["gmake: *** No targets specified and no makefile found.  Stop."], "stdout"
: "", "stdout_lines": []}
fatal: [test-joyent-smartos17-x64-3]: FAILED! => {"changed": false, "cmd": "/opt/local/bin/gmake", "msg": "gmake: *** No targets specified and no makefile found.  Stop.", "rc
": 2, "stderr": "gmake: *** No targets specified and no makefile found.  Stop.\n", "stderr_lines": ["gmake: *** No targets specified and no makefile found.  Stop."], "stdout"
: "", "stdout_lines": []}

Looking into this.

sam-github · 2019-10-28T18:32:30Z


configure:2976: gcc -o conftest    conftest.c  >&5
configure:2980: $? = 0
configure:3002: result: 
configure:3024: checking whether we are cross compiling
configure:3032: gcc -o conftest    conftest.c  >&5
In file included from /usr/include/stdio.h:37:0,
                 from conftest.c:17:
/usr/include/sys/feature_tests.h:400:2: error: #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001 applications       require the use of c99"
 #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001 applications \
  ^

sam-github · 2019-10-28T18:35:29Z

@nodejs/platform-smartos I'll bang away at above, but would appreciate any advice from people who have used SmartOS for more than 5 minutes (which is me).

sam-github · 2019-10-28T19:07:53Z

This gets further:

% ./configure CPPFLAGS=-std=c99
...
checking whether C compiler supports -Wno-implicit-fallthrough... yes
configure: creating ./config.status
./config.status: line 678: syntax error at line 716: `<<' unmatched
cat: config.h: No such file or directory
configure: now build ccache by running make
[root@f73879c5-f01c-ed18-a8bb-9eb251eb2e96 /tmp/ccache-3.6]# make
make: *** No targets specified and no makefile found.  Stop.

sam-github · 2019-10-28T19:32:25Z

Turns out ccache can only be compiled as C99, and that its configure system is not compatible with solaris' /bin/sh. See a62810f

sam-github · 2019-10-28T19:32:52Z

Next error:

fatal: [test-joyent-smartos15-x64-3]: FAILED! => {"msg": "The conditional check 'os = "ubuntu1404" and arch != "ppc64"' failed. The error was: template error while templating string: expected token 'end of statement block', got '='. String: {% if os = "ubuntu1404" and arch != "ppc64" %} True {% else %} False {% endif %}\n\nThe error appears to be in '/home/sam/w/core/build/ansible/roles/java-base/tasks/main.yml': line 7, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: install add-apt-repostory\n ^ here\n"}

sam-github · 2019-10-28T19:37:26Z

I think the conditionals were malformed, not sure how that snuck in, see 7f99d3f

sam-github · 2019-10-28T19:46:26Z

With that last change, jenkins/worker/create runs to completetion.

sam-github · 2019-10-28T19:50:04Z

Rebased onto master after #2010 landed.

sam-github · 2019-10-28T20:36:58Z

I cloned the existing -2 nodes into the new -3/-4 nodes, updated the secrets, re-ansibled, now they need firewall rules setup by @mhdawson (or someone else in @nodejs/build-infra ).

mhdawson · 2019-10-28T20:50:50Z

Firewall rules setup

ansible/ansible.cfg

sam-github · 2019-10-28T20:52:28Z

Online:

sam-github · 2019-10-28T21:16:35Z

I made the configure changes conditional on the OS, but will wait to confirm they work until the test job is quiet before re-ansibling them: https://ci.nodejs.org/job/node-test-commit-smartos

rvagg · 2019-10-28T23:48:08Z

Again, this is the hard way of doing it, I'm not objecting, just pointing it out. If you add additional machines then you have to make new entries here, secrets, ci firewall and jenkins UI. Then you'll have to do the inverse of all 4 of those things when you remove the old machines. If you just replace old machines you just have to update the ip address here and in ci firewall. You get to reuse secrets and the Jenkins entry. If you're worried about downtime because there's multiple people and potentially multiple days, these are just test machines so you could disable the entire test-node-commit-smartos and they'll be mostly unused.

Edit: Michael mentions some of the reasoning here: #2003 (comment), I'm not trying to get in the way here, just pointing out how I do it to minimise effort and duplication. Take it as you will. Thanks for taking on this work.

sam-github · 2019-10-29T14:27:19Z

I don't have strong feelings, and the extra work is already done.

As a note - the amount of time spent on copying machine defs was a 10th of the time spent getting ansilble to run without errors.

I removed the silencing of deprecation warnings, since some people find them useful.

rvagg · 2019-10-30T01:05:06Z

ansible/roles/baselayout/tasks/ccache.yml


+- name: "ccache : prepare for compilation - smartos"
+  when: os|startswith("smartos")
+  shell: bash ./configure CPPFLAGS=-std=c99


I think I remember this but may have resorted to an older version of ccache to get around it. Good change, thanks for figuring it out!

sam-github · 2019-10-30T16:46:48Z

builds green on the new smartos hosts:

https://ci.nodejs.org/job/node-test-commit-smartos/28582/

See: #2014

mhdawson approved these changes Oct 28, 2019

View reviewed changes

sam-github changed the title ~~ansible: test-joyent-smartos*-x64-[34]~~ WIP ansible: test-joyent-smartos*-x64-[34] Oct 28, 2019

sam-github mentioned this pull request Oct 28, 2019

ansible: = -> == for os check #2010

Merged

mhdawson reviewed Oct 28, 2019

View reviewed changes

ansible/ansible.cfg Outdated Show resolved Hide resolved

ansible: test-joyent-smartos*-x64-[34]

e8e81aa

rvagg reviewed Oct 30, 2019

View reviewed changes

rvagg approved these changes Oct 30, 2019

View reviewed changes

joaocgreis approved these changes Oct 30, 2019

View reviewed changes

sam-github changed the title ~~WIP ansible: test-joyent-smartos*-x64-[34]~~ ansible: test-joyent-smartos*-x64-[34] Oct 30, 2019

sam-github merged commit 5e9585a into nodejs:master Oct 30, 2019

sam-github deleted the add-smartos-3_-4 branch October 30, 2019 16:48

sam-github mentioned this pull request Nov 5, 2019

ansible: remove smartos test machines #2030

Merged

sam-github added a commit that referenced this pull request Nov 6, 2019

ansible: remove smartos test machines (#2030)

14ae6f0

See: #2014

Uh oh!

ansible: test-joyent-smartos*-x64-[34] #2014

ansible: test-joyent-smartos*-x64-[34] #2014

Uh oh!

Conversation

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

mhdawson commented Oct 28, 2019

Uh oh!

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

sam-github commented Oct 28, 2019

Uh oh!

rvagg commented Oct 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sam-github commented Oct 29, 2019

Uh oh!

rvagg Oct 30, 2019

Choose a reason for hiding this comment

Uh oh!

sam-github commented Oct 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sam-github commented Oct 28, 2019 •

edited

Loading

sam-github commented Oct 28, 2019 •

edited

Loading

rvagg commented Oct 28, 2019 •

edited

Loading